Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #168 #169

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Fix for #168 #169

merged 1 commit into from
Jul 1, 2022

Conversation

apeltzer
Copy link
Member

This removes the mirtrace_protocol as it was redundant and apparently always set to params.protocol - issue reported by @gpalidwor and fixed in this PR - see details in #168

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jun 30, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit b762e43

+| ✅ 145 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-06-30 19:23:03

@apeltzer apeltzer merged commit be94e31 into dev Jul 1, 2022
@apeltzer apeltzer deleted the fix-mirtrace-protocol branch July 14, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants