Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia package support to template #1317

Merged
merged 5 commits into from
Dec 9, 2021
Merged

Add Julia package support to template #1317

merged 5 commits into from
Dec 9, 2021

Conversation

apeltzer
Copy link
Member

@apeltzer apeltzer commented Nov 10, 2021

Adding in a line to enable support for Julia packages. Of course this is debatable, but there is no default for julia package installation like the ones for R/Python - users wanting to use Julia code with extra dependencies inside a Nextflow pipeline would be required to create a Docker container with the packages installed now at JULIA_DEPOT_PATH = "/usr/local/share/julia" to make it work with Nextflow.

My blog post is explaining a bit more in detail:

https://apeltzer.github.io/post/03-julia-lang-nextflow

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1317 (2ec2b7f) into dev (608feaa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1317   +/-   ##
=======================================
  Coverage   67.33%   67.33%           
=======================================
  Files          50       50           
  Lines        5584     5584           
=======================================
  Hits         3760     3760           
  Misses       1824     1824           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d89ec3...2ec2b7f. Read the comment docs.

@ewels
Copy link
Member

ewels commented Nov 22, 2021

So if I understand your blog post correctly, this line only really comes into play if used in combination with a custom Dockerfile, is that right? I half wonder if it makes more sense to keep this logic together with those setups rather than in the generic template for all pipelines (no nf-core pipelines will be making use of this currently, right?)

On the other hand, an extra environment variable in there shouldn't do any harm either. Unless it will break stuff for other (non nf-core official) pipelines that have figured out their own different method for using Julia? But that seems a fairly extreme edge case..

Phil

@apeltzer
Copy link
Member Author

Yes, all true. The point is that I didn't find any other Dockerfiles so far that are used in such a setting - mostly "personal" Dockerfiles for interactive work with Julia and no pipelines.

I'm also not 100% sure whats the best idea for the future when more people might want to use Julia in Nextflow pipelines - happy also to have a comment in the ENV part and therefore let people know about it? But that might be not the first place people look for something like this, too.

Bioconda etc. have not even started packaging Julia packages (and sounding from the discussion there they might never start doing that...), so there is no "community default" as of now.

@apeltzer apeltzer closed this Nov 24, 2021
@apeltzer apeltzer reopened this Nov 24, 2021
@apeltzer
Copy link
Member Author

Can do either way - maybe having the discusion here already helps some people looking for information ;-)

@ewels
Copy link
Member

ewels commented Nov 28, 2021

Maybe adding it with a comment explaining and linking to your blog post is a good compromise?

@apeltzer
Copy link
Member Author

I've added two lines of comments to the ENV description - if you meant it that way?

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, LGTM!

@ewels ewels merged commit ce28a44 into dev Dec 9, 2021
@ewels ewels deleted the add-support-for-julia-pkg branch December 9, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants