Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lint tests for old depreciated config variables #149

Merged
merged 3 commits into from Aug 17, 2018

Conversation

ewels
Copy link
Member

@ewels ewels commented Aug 16, 2018

No description provided.

@ewels ewels requested a review from a team August 16, 2018 11:38
@codecov-io
Copy link

codecov-io commented Aug 16, 2018

Codecov Report

Merging #149 into dev will increase coverage by 0.05%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #149      +/-   ##
=========================================
+ Coverage   87.15%   87.2%   +0.05%     
=========================================
  Files           7       7              
  Lines         755     766      +11     
=========================================
+ Hits          658     668      +10     
- Misses         97      98       +1
Impacted Files Coverage Δ
nf_core/utils.py 100% <100%> (ø) ⬆️
nf_core/bump_version.py 77.61% <100%> (+2.2%) ⬆️
nf_core/lint.py 96.97% <80%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d76a8c...acfd337. Read the comment docs.

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ewels ewels merged commit 5e4eeca into nf-core:dev Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants