Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove citation.cff file from pipeline template #2059

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Conversation

ggabernet
Copy link
Member

We had issues on Zenodo releases that would mention the nf-core publication instead of the pipeline name and release because of the citation.cff file.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #2059 (a2d5a26) into dev (73f6b49) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2059      +/-   ##
==========================================
+ Coverage   67.58%   67.63%   +0.04%     
==========================================
  Files          43       43              
  Lines        5572     5555      -17     
==========================================
- Hits         3766     3757       -9     
+ Misses       1806     1798       -8     
Impacted Files Coverage Δ
nf_core/components/remove.py 83.54% <0.00%> (-3.23%) ⬇️
nf_core/components/install.py 86.23% <0.00%> (-2.36%) ⬇️
nf_core/components/components_command.py 71.62% <0.00%> (-0.92%) ⬇️
nf_core/modules/test_yml_builder.py 48.63% <0.00%> (-0.91%) ⬇️
nf_core/components/list.py 68.83% <0.00%> (-0.79%) ⬇️
nf_core/modules/modules_repo.py 83.49% <0.00%> (-0.65%) ⬇️
nf_core/components/update.py 81.72% <0.00%> (+0.04%) ⬆️
nf_core/components/info.py 80.00% <0.00%> (+1.27%) ⬆️
nf_core/modules/modules_utils.py 73.80% <0.00%> (+11.01%) ⬆️
nf_core/components/components_utils.py 48.19% <0.00%> (+15.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@muffato muffato self-requested a review November 25, 2022 17:21
Copy link
Member

@muffato muffato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny minor change :)
I otherwise approve the change because 1) there is still CITATION.cff at the root of this repo (nf-core/tools) and 2) the nf-core paper is still listed in CITATIONS.nd in the pipeline template

CHANGELOG.md Outdated Show resolved Hide resolved
@ewels
Copy link
Member

ewels commented Nov 25, 2022

Bit of a shame, but ok. Kind of annoying behaviour from Zenodo! No way to disable this on the Zenodo side?

@ggabernet
Copy link
Member Author

Bit of a shame, but ok. Kind of annoying behaviour from Zenodo! No way to disable this on the Zenodo side?

Not sure, but @apeltzer has the keys to the Zenodo configuration for nf-core pipelines

@apeltzer
Copy link
Member

Not really anything configurable. Once I found time to work on using the API we can likely get around it.

Co-authored-by: Matthieu Muffato <cortexspam-github@yahoo.fr>
@ggabernet ggabernet merged commit a6af6ce into nf-core:dev Nov 28, 2022
krokicki added a commit to JaneliaSciComp/lightsheetrecon that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants