Remove fixed Ubuntu 20.04 testing workflow

[adamrtalbot]

Removes the pytest fixed version on Ubuntu:20.04 and Python 3.8 and adds it to matrix variables.

Original merge that added it: #2043

Using fewer workflows it better for enforcing code coverage etc. and managing testing throughput.

PR checklist

• This comment contains a description of changes (with reason)
• CHANGELOG.md is updated
• If you've fixed a bug or added code that should be tested, add tests!
• Documentation in docs is updated

[github-actions]

This PR is against the master branch ❌

• Do not close this PR
• Click Edit and change the base to dev
• This CI test will remain failed until you push a new commit

---

Hi @adamrtalbot,

It looks like this pull-request is has been made against the adamrtalbot/tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the adamrtalbot/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

[codecov]

Codecov Report

Merging #2397 (38f986f) into dev (3ec2697) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2397      +/-   ##
==========================================
+ Coverage   71.09%   71.14%   +0.05%     
==========================================
  Files          87       87              
  Lines        9409     9409              
==========================================
+ Hits         6689     6694       +5     
+ Misses       2720     2715       -5     

see 1 file with indirect coverage changes

[edmundmiller]

Looks good to me, I didn't know you could do that!

[edmundmiller]

Suggested change

	env:
	GITHUB_TOKEN: ${{ github.token }}

What's the purpose of adding this? Just wondering for our future selves! 😄

[adamrtalbot]

I was hitting API limits, I hoped it might authenticate by default and it seemed to help! Looking at the code I think it's just coincidence but maybe it worked.

I bet if I remove it it will break.

[edmundmiller]

Suggested change

	if: ${{ matrix.runner == 'ubuntu-20.04' && matrix.python-version == '3.8' }}
	if: ${{ matrix.runner == 'ubuntu-20.04' && matrix.python-version == '3.8' }}
	env:
	GITHUB_TOKEN: ${{ github.token }}

Is this the scope it's needed in?

[adamrtalbot]

Yep, it reflects the original test which used a couple of older versions of software together to mimic a scenario. If you look at the tests it seems to be working correctly.