Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Patch to enable PRs coming from patch branch #392

Merged
merged 3 commits into from
Sep 24, 2019
Merged

Conversation

apeltzer
Copy link
Member

After changing / testing this on hlatyping, I figured that we need to change this in linting and the template too:

https://travis-ci.com/apeltzer/hlatyping/jobs/238549269

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

@apeltzer
Copy link
Member Author

Okay, tests look like they pass 🎉

x-ref nf-core/hlatyping#66 which was used to test this properly. These tests will pass on all pipelines once we have a new tools release 👍

Copy link
Member

@sven1103 sven1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Alex, thanks for getting this on the road!

@apeltzer apeltzer merged commit b7d34e1 into dev Sep 24, 2019
@ewels ewels deleted the check-patch-travis-ci branch October 4, 2019 10:36
@ewels
Copy link
Member

ewels commented Oct 4, 2019

Nice! Would be good to update other travis files too.. eg. the mainly the one for tools 😀

@apeltzer
Copy link
Member Author

apeltzer commented Oct 4, 2019

Ok, will do that asap :-)

@apeltzer
Copy link
Member Author

apeltzer commented Oct 6, 2019

Added :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants