Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes, spacing and variable initialisation #405

Merged
merged 19 commits into from
Oct 7, 2019
Merged

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented Oct 6, 2019

Many thanks to contributing to nf-core/tools!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/tools/tree/master/.github/CONTRIBUTING.md

  • Fix Use checkIfExists #165 @ewels ?
  • Consistent spacing adjustments between code-blocks in main.nf
  • Consistent if( to if ( in template
  • Correct new ASCII logo in email_template.txt
  • Add file existence check to scrape_software_versions.py
  • Initialise params.fasta and params.genome to suppress NF warning
  • Add sensible resource labels to base.config and add example usage to fastqc process

@drpatelh drpatelh requested a review from a team October 6, 2019 23:24
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Few comments / minor suggested changes..

@drpatelh
Copy link
Member Author

drpatelh commented Oct 7, 2019

Just need to sort out whether I am implementing check_resource here too based on merging #408.

@ewels
Copy link
Member

ewels commented Oct 7, 2019

Nice work!

@ewels ewels merged commit 1baad1b into nf-core:dev Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants