Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting: Allow !>= for minimum nextflow version check #507

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Linting: Allow !>= for minimum nextflow version check #507

merged 1 commit into from
Feb 5, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Feb 5, 2020

Linting: Allow !>= as well as >= for minimum nextflow version check

Closes #506

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

@ewels ewels requested a review from a team February 5, 2020 08:48
@ewels ewels mentioned this pull request Feb 5, 2020
Closed
drpatelh
drpatelh approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@drpatelh drpatelh merged commit d514497 into nf-core:dev Feb 5, 2020
@ewels ewels deleted the lint-nf-version branch February 5, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ewels @drpatelh