Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No pipeline crash if NF version too old #344

Closed
jfy133 opened this issue Feb 3, 2020 · 6 comments
Closed

No pipeline crash if NF version too old #344

jfy133 opened this issue Feb 3, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@jfy133
Copy link
Member

jfy133 commented Feb 3, 2020

Describe the bug
Pipeline doesn't crash if minimum version not reached. Nextflow tries anyway and gives uncomprehnsiable error for a new user.

See here: https://www.nextflow.io/docs/latest/metadata.html#nextflow-metadata

if( !nextflow.version.matches('0.22+') ) {
    println "This workflow requires Nextflow version 0.22 or greater -- You are running version $nextflow.version"
    exit 1
}
@jfy133 jfy133 self-assigned this Feb 3, 2020
@jfy133 jfy133 added the bug Something isn't working label Feb 3, 2020
@apeltzer
Copy link
Member

apeltzer commented Feb 3, 2020

I thought that isn't possible when the manifest specifies a minimum version @pditommaso might know better?

@pditommaso
Copy link

it should stop when prefixing the version with !, see here. Tho, there could be an issue in recent NF versions.

@jfy133
Copy link
Member Author

jfy133 commented Feb 5, 2020

I think the ! should do it. I'll try that now.

@ewels
Copy link
Member

ewels commented Feb 5, 2020

Linting updated in nf-core/tools#507

@jfy133
Copy link
Member Author

jfy133 commented Feb 5, 2020

I suggest we merge #345 until the new version of nf-core tools is released and I'll replace with the nextflow 'native' system. Therefore leaving this open

@apeltzer apeltzer added this to the V2.1 "Ravensburg" milestone Feb 29, 2020
@apeltzer
Copy link
Member

Aligned with template now, closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants