Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev > Master for 1.1.0 release #126

Merged
merged 146 commits into from
Jun 23, 2020
Merged

Dev > Master for 1.1.0 release #126

merged 146 commits into from
Jun 23, 2020

Conversation

drpatelh
Copy link
Member

nf-core/viralrecon pull request

Many thanks for contributing to nf-core/viralrecon!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/viralrecon branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

.github/workflows/awstest.yml Outdated Show resolved Hide resolved
.github/workflows/awstest.yml Outdated Show resolved Hide resolved
.github/workflows/awstest.yml Outdated Show resolved Hide resolved
.github/workflows/awstest.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@saramonzon saramonzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Nothing to comment :)

@drpatelh
Copy link
Member Author

@ggabernet I think I am just going to ignore the AWS tests for this release. The pipeline has already been quite extensively tested on AWS so lets just hope for the best. If things break I will create a patch release.

@drpatelh
Copy link
Member Author

@maxulysse would you mind giving me a final approval if you are happy please :)

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Update GitHub actions workflows
@ggabernet ggabernet self-requested a review June 23, 2020 14:08
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

@drpatelh
Copy link
Member Author

Amazing! Thank you so much guys!!

Add plots for consensus QC
@drpatelh drpatelh merged commit 75a2f97 into master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants