Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Create unified function to check if worksheet name belongs to certain file (+ obsolete) #414

Closed
micwij opened this issue Jul 12, 2024 · 7 comments · Fixed by #424
Assignees

Comments

@micwij
Copy link

micwij commented Jul 12, 2024

Contact Details

micwij@gmail.com

Is your feature request related to a problem?

I am currently a bit stuck with an old ARC that was created some time ago with the ARCCommander, which does not open in the ARCitect. So to edit annotations I can neither use the Swate from within ARCitect nor, the Swate excel addin because these are managed by my institution.

Describe the solution you would like!

For this very specific case it would be great to be able to re-import existing isa.assay.xlsx tables and I think this might generally be useful.

Additional context!

See: nfdi4plants/ARCCommander#240

Host

Standalone

Host Details

Swate: Standalone
Browser: Microsoft Edge

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Jul 12, 2024
@Freymaurer
Copy link
Collaborator

Hello, thank you for the feedback! Can you send me a copy of the relevant file? And tell me which table triggers the issue?

@micwij
Copy link
Author

micwij commented Jul 12, 2024

Yes sure. Here is the file:
isa.assay.xlsx

If I try to use import it shows this error:

image

I just assumed that this means the import function isn't currently able to accept already filled files and expects a template file, which would maybe have the metadata sheet.

@Freymaurer
Copy link
Collaborator

No it seems to refer to this sheet:

image

Modern assays (since ARCtrl) call this sheet isa_assay.

We do have obsolete name handling. But in Swate i tried to infer the uploaded file type by the existence of a metadata sheet name and forgot to add the obsolete handling. Will fix!

@Freymaurer
Copy link
Collaborator

Done! This will be fixed with the next Swate version! Will transfer to ARCtrl to unify this logic in ActivePattern

@Freymaurer Freymaurer transferred this issue from nfdi4plants/Swate Jul 12, 2024
@Freymaurer Freymaurer changed the title [Feature Request]: Enable import of existing isa.assay.xlsx tables [Feature Request]: Create unified function to check if worksheet name belongs to certain file (+ obsolete) Jul 12, 2024
@Freymaurer
Copy link
Collaborator

@HLWeil i think it would be best to have a function, which verifies if a worksheet name belongs to assay/study/investigation, which checks for current as well as obsolete names.

@HLWeil
Copy link
Member

HLWeil commented Jul 15, 2024

Should be easy to implement. Something in the lines of:

ArcAssay.isMetadataSheetName: string -> bool

and

ArcAssay.isMetadataSheet: FsWorksheet -> bool

?

@Freymaurer
Copy link
Collaborator

Yes! Or even: ArcAssay.tryMetadataSheetName (fswb: FsWorkbook)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants