Several performance increases #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HLWeil
changed the title
Freymaurer
reviewed
Jan 30, 2024
| let expected = 1000 // this is too high and should be reduced | ||
|
|
||
| Expect.equal (wb.GetWorksheets().Count) 1 "Worksheet count" | ||
| Expect.isTrue (runtime <= expected) $"Expected conversion to be finished in under {expected}, but it took {runtime}" |
There was a problem hiding this comment.
can you abstract this as Expect.isFasterThan: (func: unit -> unit) (time: int), which runs both functions and fails if func is slower than time?
Would be much appreciated and could be added to Pyxpecto
EDIT: Maybe think of a fitting name (Expecto might have something like this) for comparing to functions against each other.
Freymaurer
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve speed of investigation file writer
Writing investigation file with many rows (e.g. 5000 studies) was very slow with quadratic time. Fixed by using the improved
rowWithRangefunction form FsSpreadsheet, which skips checking all rows on every call.Improve speed of Reading
getRowCountin every step