Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XlsxController #336

Merged
merged 3 commits into from
Apr 4, 2024
Merged

XlsxController #336

merged 3 commits into from
Apr 4, 2024

Conversation

Freymaurer
Copy link
Collaborator

  • I prove JsonController logic
  • Add XlsxController
  • Add Native tests

@Freymaurer Freymaurer requested a review from HLWeil April 4, 2024 11:47
HLWeil
HLWeil approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@HLWeil HLWeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tests/Json/Person.Tests.fs
@@ -91,12 +91,7 @@ let private tests_isa = testList "ISA" [
]

let private tests_rocrate = testList "ROCrate" [
// pending until: https://github.com/nfdi4plants/ARCtrl/issues/334
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the Issue is resolved with the new Thoth.Json.Python version?

@Freymaurer Freymaurer merged commit 9ebd796 into main Apr 4, 2024
2 checks passed
@Freymaurer Freymaurer deleted the xlsxcontroller branch April 9, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HLWeil HLWeil HLWeil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freymaurer @HLWeil