Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EXAMPLE_CreateAssayFile.js #346

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

xiaoranzhou
Copy link
Member

Fix "undefined" in column name by change the property into a function. After the change the column name is correct (Input [Source Name]).

Fix "undefined" in column name by change the property into a function. After the change the column name is correct (Input [Source Name]).
@Freymaurer Freymaurer changed the base branch from main to update_js_docs April 10, 2024 08:23
@Freymaurer
Copy link
Collaborator

Good catch! I also found some more issues with the docs and will update them!

@Freymaurer Freymaurer merged commit 789ef08 into nfdi4plants:update_js_docs Apr 10, 2024
2 checks passed
@xiaoranzhou
Copy link
Member Author

Good catch! I also found some more issues with the docs and will update them!

Thanks 😄 . The docs are generally very helpful, I will give heads-up when I found something.

By the way, I use the ARCtrl to make a SWATE template generation tool by parsing the ENA's checklist.
I use webpack to bundle the ARCtrl's javascript code and the tool is purely clientside and hosted on a GitHub page.
Now I have two questions:

  1. Do you think it make sense to integrate this tool in ARCitect or Swate? I mean, I can also create a small set of template and put them into the Swate template repo, but the selectable requirements/recommended/optional terms does offer some flexibility for a customized Swate template.
  2. Is it possible to add a URL routes so with a URL the Swate can open the template xlsx file and start annotation directly?

@Freymaurer
Copy link
Collaborator

Ah nice! I just checked it out and i might have gotten a bad example but maybe you forgot adding term source ref and term accession number to the CompositeHeader elements (see the empty brackets):
image

There is definetly room for such "extensions" we are currently working on a lot of restructuring and more features. But we will discuss when and how we could add interoperability to external tools. Feel free to give some ideas on a generalized approach for this 🙂

@xiaoranzhou
Copy link
Member Author

Thanks a lot for looking at the tool and give the helpful feedback.
I indeed forgot to add the Mandatory terms of ERC000020 to the ontology mapping files.
The ENA template generation tool parse the ENA checklists and an ontology mapping file when the webpage is opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants