Some updates for Investigation, Study and Assay profiles #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes several properties of Assay from the profile that seem to be copied from Study, as they do not correspond to any ISA properties. An exception is the creator/performer of an assay. I kept it in there, since it is also part of an ARC Assay. Furthermore, some Study and Investigation properties were changed from MUST to SHOULD.
HLWeil
approved these changes
May 27, 2024
|
The dates properties of the ISA types have also been adapted, see #4. |
This was referenced Jun 21, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes several properties of Assay from the profile that seem to be copied from Study, as they do not correspond to any ISA properties. An exception is the creator/performer of an assay. I kept it in there, since it is also part of an ARC Assay. See Issue #5 for details.
Furthermore, some Study and Investigation properties were changed from MUST to SHOULD.
@stuzart Could you have a look at this? I think we had some longer discussions about the MUST properties of Investigation, Study and Assay at the Hackathon, but in this form they fit with the ARC tools that export an RO-Crate.
I will probably add further changes for other issues (#4, #7, #9) regarding Investigation, Study and Assay to this PR as well.