Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and testing suite re-organization. #167

Merged
merged 6 commits into from
May 3, 2021

Conversation

gianbrazzini
Copy link

@gianbrazzini gianbrazzini commented May 1, 2021

Status

READY

Description

  1. Bugfixes for issues "_id" gets converted to "_d" #2, memMB gets converted to mem_m_b #4, is_snakecase("whatever_10") vs is_snakecase("whatever_1") #128.
  2. Quality of life updates to unit tests. Reorganized tests and added parametrization so that unit tests have output statements that are easier to debug.

Related PRs

n/a

Todos

  • Validate current suite of tests covers for regression.

Deploy Notes

Primary contributors or owner should validate that the current suite of unit test can cover any regression (see TODO). If any bugs are found, a unit test should be added and an appropriate fix be made.

Impacted Areas in Application

List general components of the application that this PR will affect:

  • All. Please see deploy notes.

@coveralls
Copy link

coveralls commented May 1, 2021

Pull Request Test Coverage Report for Build 487

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 483: 0.0%
Covered Lines: 79
Relevant Lines: 79

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants