Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to reload the schema without refreshing the entire … #8

Merged
merged 2 commits into from
Dec 29, 2016

Conversation

tinnou
Copy link
Contributor

@tinnou tinnou commented Dec 28, 2016

…typeRegistry.
It is the first step towards being able to add additional types that could have been omitted during the reflection process. See #6

…typeRegistry.

It enables adding additional types that could have been omitted during the reflection process.
@CLAassistant
Copy link

CLAassistant commented Dec 28, 2016

CLA assistant check
All committers have signed the CLA.

assertNotNull(typeRegistry, "TypeRegistry can't be null");
assertNotNull(schema, "GraphQLSchema can't be null");
assertNotNull(typeRegistry, "queryRoot class can't be null");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be queryRoot not typeRegistry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaant vaant merged commit 851eda6 into master Dec 29, 2016
@tinnou tinnou deleted the additional_types branch January 12, 2017 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants