Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many Neon.GitHub unit tests are failing with OverflowException #90

Closed
jefflill opened this issue Apr 10, 2024 · 3 comments
Closed

Many Neon.GitHub unit tests are failing with OverflowException #90

jefflill opened this issue Apr 10, 2024 · 3 comments
Assignees

Comments

@jefflill
Copy link
Contributor

I'll have a look after the NEONKUBE 0.11.0-beta.3 release.

@jefflill jefflill self-assigned this Apr 10, 2024
@jefflill
Copy link
Contributor Author

Unfortunately, this appears to be impacting the neon-kube tool and the release process. We may need to upgrade nugets.

I notice that LibGit2Sharp v0.27.2 is depreciated due to a critical security issue and should be upgraded to v0.30.0**:

GHSA-j2v7-4f6v-gpg8

...and we're still using our custom Neon.Octokit nuget but I believie they accepted our pull request some time ago, so we should probably switch back to the official OctoKit.

@jefflill
Copy link
Contributor Author

jefflill commented Apr 11, 2024

It also looks like octokit.net is using 32-bit integers incorrectly to hold GitHub (some or all?) object IDs and GitHub must not be exceeding this now:

octokit/octokit.net#2893

Octokit v11.0.0 was just released yesterday (4/10/2024) and that seems to fix the overflow issue (although the issue is still open).

Now I'm looking into the missing LibGit2Sharp: CloneOptions.CredentialsProvider property.

@jefflill
Copy link
Contributor Author

FIXED: Upgraded to octokit.net v11.0.0 and LibGit2Sharp v0.30.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant