Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Defer to solver" - and PHP warning ... #14

Open
nfreear opened this issue Aug 24, 2015 · 0 comments
Open

Fix "Defer to solver" - and PHP warning ... #14

nfreear opened this issue Aug 24, 2015 · 0 comments

Comments

@nfreear
Copy link
Owner

nfreear commented Aug 24, 2015

PHP warning : undefined variable link:

Nick@~/workspace/player-packages/composer-suggest (master=)$ git diff

diff --git a/src/Suggest.php b/src/Suggest.php
index a0a10e4..507c731 100644
--- a/src/Suggest.php
+++ b/src/Suggest.php
@@ -162,7 +162,7 @@ EOF;
             } else {
                 // Defer to solver. TODO: ?
                 self::debug("Deferring duplicate <comment>{$name}</comment>");
-                $dups[] = $link;
+                $dups[ $name ] = $constraint;
             }
         }
         return $origin;
nfreear added a commit that referenced this issue Aug 24, 2015
* Allow duplicate Composer packages names in suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant