Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): fix can't render due to inherited #1592

Merged
merged 2 commits into from
Apr 16, 2023
Merged

fix(form): fix can't render due to inherited #1592

merged 2 commits into from
Apr 16, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Apr 16, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Apr 16, 2023

Preview is ready!

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #1592 (9f67ed3) into master (113c686) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9f67ed3 differs from pull request most recent head e41bb2d. Consider uploading reports for the commit e41bb2d to get more accurate results

@@           Coverage Diff           @@
##           master    #1592   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files         276      276           
  Lines        8497     8497           
  Branches     1660     1576   -84     
=======================================
  Hits         8117     8117           
  Misses        318      318           
  Partials       62       62           
Impacted Files Coverage Δ
packages/form/src/model/form.property.ts 98.00% <100.00%> (ø)
packages/form/src/sf.component.ts 96.58% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cipchk cipchk merged commit d14c866 into master Apr 16, 2023
@cipchk cipchk deleted the issues-2375 branch January 1, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

动态表单Object对象类型的两个疑似Bug
2 participants