feat(alert): self-closing alerts are non-dismissible by default #676
Conversation
| private _popupService: PopupService<NgbAlert>; | ||
| private _timeout; | ||
|
|
||
| /** | ||
| * A flag indicating if the alert can be dismissed (closed) by a user. If this flag is set, a close button (in a | ||
| * form of a cross) will be displayed. |
There was a problem hiding this comment.
×? "times"? "x"? just a stupid nit here on my part, but i think of "cross" as a plus.
There was a problem hiding this comment.
ok, i'm confused. how are these lines showing up as "new" when they are already present in the original file?
There was a problem hiding this comment.
The lines appear in the source of NgbAlert (the "regular" alert component). This is a new input for NgbSelfClosingAlert, previously named NgbDismissibleAlert, which didn't have such an input: the close button was always visible in such alerts, despite the fact that they can close themselves automatically.
So I added the equivalent input here and copy-pasted the api doc from NgbAlert, to be able to show or hide the close buttons on self-closing alerts too. I also chose to make the button invisible by default, since this component is self-closing and thus doesn't need a close button most of the time.
I'll amend the PR with "an ×" instead of "a cross".
|
@jnizet just the one question and LGTM. |
- refactor NgbDismissibleAlert to NgbSelfClosingAlert - make it possible to hide the close button on self-closing alerts - make the self-closing alert tests a bit less convoluted fix ng-bootstrap#660
jnizet
force-pushed
the
refactor/alerts
branch
from
f254a88
to
fa4732d
Compare
fix #660