move NixOS VM tests to checks output
#247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mightyiam the mCaptcha VM test fails, and you were the last one to touch the code. Looks like some database schema mismatch, maybe due to an incompatible change between version updates? https://buildbot.ngi.nixos.org/#/builders/88/builds/4/steps/1/logs/stdio |
|
Do you intend to rebase this or would you like us (@ngi-nix/magic @ngi-nix/cake) to do it? |
fricklerhandwerk
force-pushed
the
move-nixos-tests-to-checks
branch
from
5181cef
to
c21df2a
Compare
- this should capture all the tests to be run by buildbot - remove all remnants of Hydra builds
fricklerhandwerk
force-pushed
the
move-nixos-tests-to-checks
branch
from
c21df2a
to
c6842cb
Compare
|
@stepbrobd thanks, I'll manage :) |
|
@Erethon @lorenzleutgeb by the way, the new CI is amazing. Pure refactorings like these finish checks in << 1min. |
fricklerhandwerk
commented
Jun 7, 2024
lorenzleutgeb
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
LGTM to me now that I refactored it, lol. Passing the ball back to @fricklerhandwerk for further review or merge.
fricklerhandwerk
commented
Jun 7, 2024
fricklerhandwerk
commented
Jun 7, 2024
fricklerhandwerk
commented
Jun 7, 2024
Closed
|
Thank you! |
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should capture all the tests to be run by buildbot
it also effectively deprecates Hydra builds
paired with @Erethon; please run the formatter (development shell doesn't work on Darwin)