Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add experimental feature no-url-literals #44

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

lorenzleutgeb
Copy link
Member

@lorenzleutgeb lorenzleutgeb commented Sep 6, 2023

Closes #39

@lorenzleutgeb lorenzleutgeb marked this pull request as ready for review September 6, 2023 10:32
Copy link
Collaborator

@cleeyv cleeyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To verify that this is working as intended, I made the same change to the ci.yaml of an older branch, prior to the disabling of liberaforms and its dependency on an old version of nixpkgs. This successfully returned an error that included error: URL literals are disabled: https://github.com/ngi-nix/ngipkgs/actions/runs/6101536919/job/16558075410

@lorenzleutgeb lorenzleutgeb merged commit 6cf4dba into main Sep 6, 2023
2 checks passed
@lorenzleutgeb lorenzleutgeb deleted the no-url-literals branch September 6, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: mobleted
Development

Successfully merging this pull request may close these issues.

nix flake check with no-url-literals fails
2 participants