Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make server_tokens configurable per virtual-host #1620

Merged
merged 1 commit into from
May 13, 2021

Conversation

alekna
Copy link
Contributor

@alekna alekna commented May 11, 2021

Makes server_tokens configurable per virtual-host without need to build custom images or mount custom configuration.

Sample docker-compose:

version: '2'

services:
  nginx-proxy:
    image: nginxproxy/nginx-proxy
    ports:
      - "80:80"
    volumes:
      - /var/run/docker.sock:/tmp/docker.sock:ro

  whoami:
    image: jwilder/whoami
    expose:
      - "8000"
    environment:
      - VIRTUAL_HOST=whoami.local
      - VIRTUAL_PORT=8000
      - SERVER_TOKENS=off

Fixes #1094 #1418

@buchdag buchdag added the kind/feature-request Issue requesting a new feature label May 11, 2021
@alekna
Copy link
Contributor Author

alekna commented May 13, 2021

It's quite commonly requested feature and something I'm also looking to have as a built-in feature in nginx-proxy. @buchdag what are the odds of this change being accepted? Is there anything you would like me to improve in my PR?

@buchdag
Copy link
Member

buchdag commented May 13, 2021

@alekna I made a review on this PR with two very minor changes, as soon as those changes are made I'll merge this.

@alekna
Copy link
Contributor Author

alekna commented May 13, 2021

I don't see any changes requested. Would you mind sharing it with me so that I could make adjustments?

test/test_headers/test_http.yml Show resolved Hide resolved
test/test_headers/test_https.yml Show resolved Hide resolved
@buchdag
Copy link
Member

buchdag commented May 13, 2021

My bad, I did not submit it.

Copy link
Member

@buchdag buchdag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request Issue requesting a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Nginx Version
2 participants