Skip to content

Use trim to handle VIRTUAL_HOST values with spaces #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2015

Conversation

mariusGundersen
Copy link
Contributor

based on latest docker-gen

jwilder added a commit that referenced this pull request Oct 14, 2015
Use trim to handle VIRTUAL_HOST values with spaces
@jwilder jwilder merged commit 1670bcc into nginx-proxy:master Oct 14, 2015
@jwilder
Copy link
Collaborator

jwilder commented Oct 14, 2015

Thanks @mariusGundersen!

@md5
Copy link
Contributor

md5 commented Oct 14, 2015

Even with this change, there will still be problems with spaces if any custom config files are used since the $host variable will still have extraneous space in those exists checks. I think it would be best to do something like {{ $host := trim $host }} (and the same for $proto).

@jwilder
Copy link
Collaborator

jwilder commented Oct 14, 2015

Good point @md5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants