docs: add precisions to multi container compose file #2650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added precision for 3-container version
buchdag
requested changes
Aug 19, 2025
There was a problem hiding this comment.
I'm not sure that the usage of network_mode: "none" and the internal network feature should be made default in the compose examples without any explanation. The usage of network_mode on a service is also mutually exclusive with networks for the entire compose file and I don't think it's a good idea to suggest this as the base example.
The compose file are meant to serve as minimalist examples, and users are supposed to read the doc and build from there.
|
I accept your comment regarding "network_mode". |
Co-authored-by: Nicolas Duchon <nicolas.duchon@gmail.com>
buchdag
changed the title
buchdag
approved these changes
Aug 20, 2025
|
Thanks @Bob-le-pirate 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added precision for 3-container version