Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alpine plus dockerfile on alpine>=3.17 #511

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

Dean-Coakley
Copy link
Contributor

Description of issue

alpine>=v3.17 upgrades openssl version v1.1.1w -> v3.0.x which brings a slight format change which broke key verification.

Openssl v1 format:

$ openssl rsa -pubin -in /tmp/nginx_signing.rsa.pub -text -noout
RSA Public-Key: (2048 bit)
Modulus:
    00:fe:14:f6:0a:1a:b8:86:19:fe:cd:ab:02:9f:58:
...

Openssl v3 format:

$ openssl rsa -pubin -in /tmp/nginx_signing.rsa.pub -text -noout
Public-Key: (2048 bit)
Modulus:
    00:fe:14:f6:0a:1a:b8:86:19:fe:cd:ab:02:9f:58:
...

Proposed changes

  • Update expected key to match openssl=v3.0.x format
  • Add sed replace to make old output format verify successfully against new key
  • Add note so sed can be easily and safely removed in the future

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@Dean-Coakley Dean-Coakley added the bug Something isn't working label Nov 6, 2023
@Dean-Coakley Dean-Coakley self-assigned this Nov 6, 2023
Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit e427b12
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/65490c2ecbf03000082035e4

@codecov-commenter
Copy link

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (a1b3635) 66.27% compared to head (e427b12) 66.25%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   66.27%   66.25%   -0.02%     
==========================================
  Files         118      118              
  Lines       13454    13457       +3     
==========================================
  Hits         8916     8916              
+ Misses       3944     3943       -1     
- Partials      594      598       +4     
Files Coverage Δ
src/core/config/types.go 0.00% <ø> (ø)
src/core/config/defaults.go 13.63% <50.00%> (+13.63%) ⬆️
src/core/config/config.go 70.34% <33.33%> (+1.07%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dean-Coakley Dean-Coakley merged commit 0854fe6 into main Nov 15, 2023
28 checks passed
@Dean-Coakley Dean-Coakley deleted the fix-alpine-dockerfile branch November 15, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants