Config Download #540
Merged
Config Download #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphralG
requested review from
oliveromahony,
dhurley,
Dean-Coakley,
craigell and
olli-holmala
dhurley
reviewed
Jan 16, 2024
Co-authored-by: Olli Holmala <85518764+olli-holmala@users.noreply.github.com>
olli-holmala
approved these changes
Jan 17, 2024
Dean-Coakley
approved these changes
Jan 18, 2024
|
|
||
| func NewHttpConfigClient() *HttpConfigClient { | ||
| httpClient := http.Client{ | ||
| Timeout: time.Second * 10, |
There was a problem hiding this comment.
can you move this to a config setting?
| files := instances.Files{} | ||
|
|
||
| req, err := http.NewRequest(http.MethodGet, filesUrl, nil) | ||
| req.Header.Set("tenantId", tenantID.String()) |
There was a problem hiding this comment.
tenantId is probably better as a constant
| @@ -0,0 +1,83 @@ | |||
| package datasource | |||
There was a problem hiding this comment.
copywrite header missing
| ) | ||
|
|
||
| // map of files with filepath as key | ||
| type FileCache = map[string]*instances.File |
There was a problem hiding this comment.
should this type be visible outside of this file?
There was a problem hiding this comment.
Yes as its needed in config writer
oliveromahony
approved these changes
Jan 18, 2024
dhurley
approved these changes
Jan 18, 2024
|
|
||
| ConfigWriterParameters struct { | ||
| configDownloader client.HttpConfigClientInterface | ||
| client Client |
There was a problem hiding this comment.
Suggested change
| client Client | |
| Client Client |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)