Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add update instance config endpoint #542

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Add update instance config endpoint #542

merged 4 commits into from
Jan 19, 2024

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Jan 18, 2024

Proposed changes

  • Add update instance config endpoint.
  • Add instance monitor plugin.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley self-assigned this Jan 18, 2024
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jan 18, 2024
olli-holmala
olli-holmala approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@olli-holmala olli-holmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhurley dhurley merged commit f0ae1de into v3 Jan 19, 2024
2 checks passed
@dhurley dhurley deleted the update-instance-config-rest-api branch January 19, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@olli-holmala olli-holmala olli-holmala approved these changes

@oliveromahony oliveromahony Awaiting requested review from oliveromahony

@craigell craigell Awaiting requested review from craigell

Assignees

@dhurley dhurley

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhurley @Dean-Coakley @olli-holmala @aphralG