Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Agent v2 and v3 metrics pages. #800

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Aug 22, 2024

PR in progress.

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

This commit adds the Agent v2 metrics catalogue to the new v2
subsection. It is achieved by copying the existing catalogue within the
NGINX Management Suite documentation, since it covers the same content.
@ADubhlaoich ADubhlaoich self-assigned this Aug 22, 2024
@ADubhlaoich ADubhlaoich marked this pull request as draft August 22, 2024 16:01
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 22, 2024
Copy link
Contributor

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-agent/800/

@ADubhlaoich ADubhlaoich changed the title feat: Add Agent v2 metrics catalogue Add v2 and v3 metrics documents Aug 22, 2024
@ADubhlaoich ADubhlaoich changed the title Add v2 and v3 metrics documents Add Agent v2 and v3 metrics pages. Aug 22, 2024
@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Aug 29, 2024
@ADubhlaoich ADubhlaoich marked this pull request as ready for review September 23, 2024 14:23
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner September 23, 2024 14:23
@ADubhlaoich
Copy link
Contributor Author

Merging this now as the V2 metrics are complete: I will open a separate PR and branch for V3 once they are ready.

@ADubhlaoich ADubhlaoich merged commit 671a2ed into v3-documentation Sep 23, 2024
22 checks passed
@ADubhlaoich ADubhlaoich deleted the v3-2-metrics branch September 23, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants