Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed out-of-bounds reads and writes. #796

Closed
wants to merge 1 commit into from
Closed

Fixed out-of-bounds reads and writes. #796

wants to merge 1 commit into from

Conversation

alejandro-colomar
Copy link
Contributor 

This patch fixes out-of-bounds reads and writes by placing some checks in the
right place.  However, this is only a workaround, and proper fixing requires:

-  Changing nxt_sprintf() to detect truncation.
-  Changing/adding other string copy functions to detect truncation.

Fixes: c554941b ("Initial applications isolation support using Linux namespaces.")
Fixes: e2b53e16 ("Added "rootfs" feature.")
Closes: <https://github.com/nginx/unit/issues/795>
Cc: Andrei Zeliankou <zelenkov@nginx.com>
Cc: Zhidao HONG <z.hong@f5.com>
Cc: Andrew Clayton <a.clayton@nginx.com>
Signed-off-by: Alejandro Colomar <alx@nginx.com>

@alejandro-colomar alejandro-colomar linked an issue Dec 1, 2022 that may be closed by this pull request
Undefined Behavior: write past the end of an array #795
Open
@alejandro-colomar
Fixed out-of-bounds reads and writes.
194deeb 
This patch fixes out-of-bounds reads and writes by placing some checks in the
right place.  However, this is only a workaround, and proper fixing requires:

-  Changing nxt_sprintf() to detect truncation.
-  Changing/adding other string copy functions to detect truncation.

Fixes: c554941 ("Initial applications isolation support using Linux namespaces.")
Fixes: e2b53e1 ("Added "rootfs" feature.")
Closes: <#795>
Cc: Andrei Zeliankou <zelenkov@nginx.com>
Cc: Zhidao HONG <z.hong@f5.com>
Cc: Andrew Clayton <a.clayton@nginx.com>
Signed-off-by: Alejandro Colomar <alx@nginx.com>
@alejandro-colomar alejandro-colomar deleted the ub_array branch July 1, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ac000 ac000 Awaiting requested review from ac000

@andrey-zelenkov andrey-zelenkov Awaiting requested review from andrey-zelenkov

@hongzhidao hongzhidao Awaiting requested review from hongzhidao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined Behavior: write past the end of an array
1 participant
@alejandro-colomar