Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve uninstalling NGINX capabilities #472

Merged
merged 18 commits into from
Dec 7, 2021
Merged

Improve uninstalling NGINX capabilities #472

merged 18 commits into from
Dec 7, 2021

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Dec 3, 2021

Proposed changes

BREAKING CHANGES:

  • The nginx_state variable has been replaced with nginx_setup and instead of using present, absent, latest you should now use install, uninstall and update.
  • nginx_install variable is no more. Use nginx_enable instead.

BUG FIXES:

Uninstalling NGINX should now work correctly under most scenarios.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Dec 3, 2021
@github-actions github-actions bot added the breaking change Implies a breaking change label Dec 3, 2021
@alessfg alessfg added the bug Something isn't working label Dec 3, 2021
@alessfg alessfg added this to the 0.21.4 milestone Dec 3, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
defaults/main/main.yml Outdated Show resolved Hide resolved
tasks/modules/install-modules.yml Outdated Show resolved Hide resolved
@alessfg alessfg merged commit 5f1fc18 into main Dec 7, 2021
@alessfg alessfg deleted the uninstall-nginx branch December 7, 2021 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Implies a breaking change bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants