Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Molecule CI/CD to support NGINX 1.25.2 #649

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Aug 28, 2023

Proposed changes

  • Reimplement some platforms in the upgrade & downgrade Molecule scenarios since all platforms now have at least two releases.
  • Replace the hardcoded NGINX version check in multiple Molecule scenarios with a dynamic NGINX version check.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Aug 28, 2023
@github-actions github-actions bot added the tests Improvements to tests label Aug 28, 2023
@alessfg alessfg added this to the 0.24.2 milestone Aug 28, 2023
@alessfg alessfg merged commit a528e23 into main Aug 29, 2023
14 checks passed
@alessfg alessfg deleted the update-tests-1.25.2 branch August 29, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Improvements to tests
Development

Successfully merging this pull request may close these issues.

1 participant