Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local role name in Molecule tests #682

Merged
merged 3 commits into from
Dec 23, 2023
Merged

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Dec 22, 2023

Proposed changes

Use the local role name (ansible-role-nginx) instead of the fully qualified role name (nginxinc.nginx) in Molecule to ensure tests always work as intended in environments where the role has been already installed beforehand.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document.
  • I have added Molecule tests that prove my fix is effective or that my feature works.
  • I have checked that any relevant Molecule tests pass after adding my changes.
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md).

@alessfg alessfg self-assigned this Dec 22, 2023
@alessfg alessfg added bug Something isn't working tests Improvements to tests labels Dec 22, 2023
@alessfg alessfg added this to the 0.24.3 milestone Dec 22, 2023
@alessfg alessfg merged commit 6976aec into main Dec 23, 2023
16 checks passed
@alessfg alessfg deleted the revert-molecule-role-name branch December 23, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Improvements to tests
Development

Successfully merging this pull request may close these issues.

1 participant