Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need hooks for testing #7

Closed
dgrijalva opened this issue Apr 14, 2012 · 1 comment
Closed

Need hooks for testing #7

dgrijalva opened this issue Apr 14, 2012 · 1 comment

Comments

@dgrijalva
Copy link
Contributor

While trying to unit test my own request filters, I realized it's very difficult as I can't create my own complete falcore.Request objects.

@smw1218
Copy link
Contributor

smw1218 commented Jul 3, 2012

This was a bit tricky since the request needed to do some bookkeeping around the filter call, added a new func TestWithRequest(request _http.Request, filter RequestFilter) (_Request, *http.Response).

I hope this is enough to enable testing since the lifecycle stuff would be messy to expose and exposing the internal newRequest would return a mostly broken object.

@smw1218 smw1218 closed this as completed Jul 3, 2012
dgrijalva added a commit to dgrijalva/falcore that referenced this issue Apr 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants