Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 clear all initial values when clearing complete store #30

Merged
merged 1 commit into from
Jun 27, 2021

Conversation

adrianriepl
Copy link
Contributor

Clears complete Map of initial values when the store is getting cleared.

Closes: #29

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

When calling the methods formsManager.clear() or formsManager.destroy() without parameters the existing initial values are not being cleared.

Issue Number: #29

What is the new behavior?

All initial values are now being cleared when clearing the complete store.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Clears complete Map of initial values when the store is getting cleared.

Closes: ngneat#29
@NetanelBasal NetanelBasal merged commit 081a84e into ngneat:master Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial values not being cleared using blank clear or destroy methods
2 participants