Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use spread operator on valid dates #8

Merged
merged 1 commit into from
May 27, 2020
Merged

fix: do not use spread operator on valid dates #8

merged 1 commit into from
May 27, 2020

Conversation

dspeirs7
Copy link
Contributor

@dspeirs7 dspeirs7 commented May 26, 2020

To ensure that isObject does not return true for dates to avoid using the spread operator on a date causing it to be an empty object.

PR Close #7

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

(#7)

Issue Number:7

What is the new behavior?

A date value is not cloned using the spread operator leaving it as an empty object.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

To ensure that isObject does not return true for dates to avoid using the spread operator on a date causing it to be an empty object.

PR Close #7
@NetanelBasal NetanelBasal merged commit 27d0dcc into ngneat:master May 27, 2020
@NetanelBasal
Copy link
Member

Please add yourself to the contributors. npm run contributors:add

@dspeirs7 dspeirs7 deleted the fixDateValue branch May 27, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mat Date Picker value doesn't persist to local storage
2 participants