Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make createSpyObject public (#316) #317

Merged

Conversation

kremerd
Copy link
Contributor

@kremerd kremerd commented Jun 10, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #316

What is the new behavior?

createSpyObject is public api also for Jest.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@NetanelBasal
Copy link
Member

Add yourself to the contributors' list. Run npm run contributors:add

@kremerd
Copy link
Contributor Author

kremerd commented Jun 10, 2020

Thanks for the attribution! It seems you already did that for me, though.

@NetanelBasal NetanelBasal merged commit bb128df into ngneat:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants