Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): respect the skipTests option #370

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

matheo
Copy link
Contributor

@matheo matheo commented Dec 1, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

I understand that the purpose of the schematics is to add spectator's unit tests
but while using these as the default for an Angular App, or extending them,
we need to respect the executions with --skipTests.

What is the new behavior?

Do not create spec files when the schematic is executed with --skipTests.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Thanks a lot for this cool library!

@NetanelBasal NetanelBasal merged commit c9ff534 into ngneat:master Dec 1, 2020
@matheo
Copy link
Contributor Author

matheo commented Dec 1, 2020

@NetanelBasal can we have a patch release please? :)

@matheo matheo deleted the fix/schematics branch December 1, 2020 19:22
@NetanelBasal
Copy link
Member

Done

@matheo
Copy link
Contributor Author

matheo commented Dec 2, 2020

tyvm!

ntvsx193 pushed a commit to ntvsx193/spectator that referenced this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants