Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add code to KeyboardEvent #512

Merged
merged 1 commit into from
Nov 14, 2021
Merged

fix: add code to KeyboardEvent #512

merged 1 commit into from
Nov 14, 2021

Conversation

adrianrutkowski
Copy link
Contributor

@adrianrutkowski adrianrutkowski commented Nov 12, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

code property, which is favored over deprecated keyCode is not added to KeyboardEvent

Issue Number: #501

What is the new behavior?

code property is added to KeyboardEvent

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@NetanelBasal NetanelBasal merged commit 8b6f2b0 into ngneat:master Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants