Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 🎡 align jest v29 dependencies #621

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

chimurai
Copy link
Contributor

@chimurai chimurai commented Jul 2, 2023

  • remove transitive jest@28 and ts-jest@28 dependencies from yarn.lock
  • fix ts-jest warnings in console when running "yarn test:jest"
ts-jest[ts-jest-transformer] (WARN) Define `ts-jest` config under `globals` is deprecated. Please do
transform: {
    <transform_regex>: ['ts-jest', { /* ts-jest config goes here in Jest */ }],
},

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

console is full of warnings:

image

jest28 is still installed:

image

Issue Number: N/A

What is the new behavior?

No more warnings in console:

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- remove transitive jest@28 and ts-jest@28 dependencies from yarn.lock
- fix ts-jest warnings in console when running "yarn test:jest"

```shell
ts-jest[ts-jest-transformer] (WARN) Define `ts-jest` config under `globals` is deprecated. Please do
transform: {
    <transform_regex>: ['ts-jest', { /* ts-jest config goes here in Jest */ }],
},
```
@stackblitz
Copy link

stackblitz bot commented Jul 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NetanelBasal NetanelBasal merged commit 3a7fc53 into ngneat:master Jul 3, 2023
@chimurai chimurai deleted the jest29-deps-alignment branch July 3, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants