Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

Nodejs Compatibility #3

Open
CEbbinghaus opened this issue Apr 1, 2023 · 2 comments
Open

Nodejs Compatibility #3

CEbbinghaus opened this issue Apr 1, 2023 · 2 comments

Comments

@CEbbinghaus
Copy link
Contributor

Now I know this isn't a priority but it would be nice if lines 45-46 in usdpl-front/src/connection.rs

let window = web_sys::window().unwrap();
let resp_value = JsFuture::from(window.fetch_with_request(&request)).await?;

could be changed to not rely on the "window" object but instead, just call fetch directly. As such would make it possible to run from nodejs which also has a built-in fetch function.

@NGnius
Copy link
Owner

NGnius commented Apr 2, 2023

I'm not actually sure how do that through Rust's WASM bindings, but I don't see why it wouldn't be possible.

There's a lot of technical debt in this project right now because I've only been adding to it when I need to do something fancy in a Decky plugin. With a bit of luck this will be fixed along with the refactor/rewrite for #2 ... whenever I have some motivation to do that.

@CEbbinghaus
Copy link
Contributor Author

I raised an issue in rustwasm/wasm-bindgen#3377 to add support for cross-runtime fetch support which would hopefully make it simple enough to fix this too. Until then that is the main blocker for this Issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants