Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CX. #88

Merged
merged 16 commits into from
Oct 15, 2019
Merged

Implement CX. #88

merged 16 commits into from
Oct 15, 2019

Conversation

s-mandra
Copy link
Member

No description provided.

@s-mandra s-mandra added the enhancement New feature or request label Oct 13, 2019
@s-mandra s-mandra added this to the qFlex initial release milestone Oct 13, 2019
@s-mandra s-mandra mentioned this pull request Oct 13, 2019
Closed
@s-mandra
Copy link
Member Author

I still need to adjust few things ..

@s-mandra
Copy link
Member Author

Fixing SVD for CX.

@s-mandra s-mandra closed this Oct 13, 2019
@s-mandra s-mandra reopened this Oct 14, 2019
@s-mandra s-mandra mentioned this pull request Oct 14, 2019
Closed
@s-mandra s-mandra self-assigned this Oct 14, 2019
benjaminvillalonga
benjaminvillalonga approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@benjaminvillalonga benjaminvillalonga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I commented out the sparse version and added dense version of cx.

@s-mandra s-mandra merged commit 998f0b3 into master Oct 15, 2019
@benjaminvillalonga benjaminvillalonga deleted the implement-cx branch October 23, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminvillalonga benjaminvillalonga benjaminvillalonga approved these changes

Assignees

@s-mandra s-mandra

Labels
enhancement New feature or request
Projects
None yet
Milestone
qFlex initial release
Development

Successfully merging this pull request may close these issues.
3 participants
@s-mandra @benjaminvillalonga @dagart