Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module build failed: ReferenceError: Promise is not defined #5

Closed
RSpace opened this issue Dec 22, 2015 · 2 comments
Closed

Module build failed: ReferenceError: Promise is not defined #5

RSpace opened this issue Dec 22, 2015 · 2 comments

Comments

@RSpace
Copy link
Contributor

RSpace commented Dec 22, 2015

I'm getting this error when I run npm run serve-js. It's fixable by adding require('es6-promise').polyfill(); to webpack.config.js and a dev dependency on es6-promise. Should I submit a pull request for this workaround, or is there a better to fix it?
@ngokevin
Copy link
Owner

Good catch. Yeah, that sounds good to me. You could also try require('babel-polyfill') since that's already a dep.

@ngokevin
Copy link
Owner

A PR would be great 😃

RSpace added a commit to RSpace/aframe-react-boilerplate that referenced this issue Dec 22, 2015
@RSpace
Require babel polyfill in webpack config to make Promise available to…
679e20d 
… the webpack build. Fixes ngokevin#5
@RSpace RSpace mentioned this issue Dec 22, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RSpace @ngokevin