Use empty username when username is not present in snapshot. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in snapshot. This commit is fixing a crash when the snapshot has no username field in JSON. The missing username is replaced with a space.
|
Thank you. Could you check in restic cli if there is something in the user column. I'm ok with an empty value but maybe "unknown" or some value is more useful. |
|
The JSON produced by the Without the |
|
Thank you. I will merge it and publish a new release this weekend. |
ngosang
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is fixing a crash when the snapshot has no username field in JSON. The missing username is replaced with a space.
(I have snapshots of my smartphone where the
usernamekey is missing)