Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade build process to emit ESM modules and a UMD bundle #6

Merged
merged 1 commit into from
Sep 15, 2016

Conversation

MikeRyanDev
Copy link
Member

No description provided.

@MikeRyanDev
Copy link
Member Author

@brandonroberts I'm worried that deep import paths will break for users now that the module format has been switched to ESM. Example:

import { compose } from '@ngrx/core/compose';

Thinking this should be released as v2.0 and all dependents should accept a semver range of ^1.0.0 || ^2.0.0

@brandonroberts
Copy link
Member

LGTM. The import update should be noted as a breaking change.

@NathanWalker
Copy link

@MikeRyan52 Curious on merge status if you don't mind me asking?
That core peerDep issue is tough with rc.7 at moment ;)

@MikeRyanDev
Copy link
Member Author

Augmented the build to include legacy CJS output. Imports like @ngrx/core/add/operator/select will continue to work.

@MikeRyanDev
Copy link
Member Author

Published as v1.2.0

cc @NathanWalker

@NathanWalker
Copy link

I'm dancing. Like. actually... dancing. Thank you @MikeRyan52 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants