fix(schematics): check for empty name when using store schematic for feature states (#1659) (#1666)

Closes #1659

Author: EnricoVogt

modules/schematics/src/store/index.spec.ts

@@ -215,4 +215,27 @@ describe('Store Schematic', () => {
     );
     expect(content).toMatch(/export interface FeatureState {/);
   });
+
+  it('should fail if a feature state name is not specified', () => {
+    const options = {
+      ...defaultOptions,
+      name: undefined,
+      root: false,
+    };
+
+    expect(() => {
+      schematicRunner.runSchematic('store', options, appTree);
+    }).toThrowError('Please provide a name for the feature state');
+  });
+
+  it('should pass if a root state name is not specified', () => {
+    const options = {
+      ...defaultOptions,
+      name: undefined,
+    };
+
+    expect(() => {
+      schematicRunner.runSchematic('store', options, appTree);
+    }).not.toThrow();
+  });
 });

modules/schematics/src/store/index.ts

@@ -131,9 +131,13 @@ function addImportToNgModule(options: StoreOptions): Rule {
 
 export default function(options: StoreOptions): Rule {
   return (host: Tree, context: SchematicContext) => {
+    if (!options.name && !options.root) {
+      throw new Error(`Please provide a name for the feature state`);
+    }
+
     options.path = getProjectPath(host, options);
 
-    const parsedPath = parseName(options.path, options.name);
+    const parsedPath = parseName(options.path, options.name || '');
     options.name = parsedPath.name;
     options.path = parsedPath.path;