fix(store): replace Creator with ActionCreator on createAction (#2299)

* fix(store): replace insufficient type Creator with TypedCreator

createAction returns incorrect type as neither Creator not it's return type contains `type`.
Proper return type is ActionCreator with inner typed creator

Closes meeroslav/ng-helpers#2

* fix(store): revert TypedCreator in favor of upcoming NotAllowedCheck

Author: meeroslav

modules/store/src/action_creator.ts

@@ -100,7 +100,7 @@ export function createAction<
 export function createAction<T extends string, C extends Creator>(
   type: T,
   config?: { _as: 'props' } | C
-): Creator {
+): ActionCreator<T> {
   if (typeof config === 'function') {
     return defineType(type, (...args: any[]) => ({
       ...config(...args),
@@ -133,7 +133,10 @@ export function union<
   return undefined!;
 }
 
-function defineType(type: string, creator: Creator): Creator {
+function defineType<T extends string>(
+  type: T,
+  creator: Creator
+): ActionCreator<T> {
   return Object.defineProperty(creator, 'type', {
     value: type,
     writable: false,