You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Which @ngrx/* package(s) are the source of the bug?
store-devtools
Minimal reproduction of the bug/regression with instructions
When compiling with the new esbuild system in Angular 17 (https://angular.io/guide/esbuild), the following warning is generated:
Using direct eval with a bundler is not recommended and may cause problems [direct-eval]
node_modules/@ngrx/store-devtools/fesm2022/ngrx-store-devtools.mjs:423:42:
432 | ....return typeof action === 'string' ? eval(`(${action})`) : action;
| ~~~~
You can read more about direct eval and bundling here: https://esbuild.github.io/link/direct-eval
Expected behavior
No warnings should be generated.
Versions of NgRx, Angular, Node, affected browser(s) and operating system(s)
NgRx: 17.0.1
Angular: 17.0.8
Other information
No response
I would be willing to submit a PR to fix this issue
Yes
No
The text was updated successfully, but these errors were encountered:
`unwrapAction` internally runs `eval` if the argument
is of type `string`.
It is unclear why that `unwrapAction` was necessary
in the first place and it looks like an artifact
from a former version. The line was added
in 2018.
Since `eval` is not best practice and according to ngrx#4213,
esbuild has issues with it, it is removed.
`unwrapAction` internally runs `eval` if the argument
is of type `string`.
It is unclear why that `unwrapAction` was necessary
in the first place, and it looks like an artifact
from a older codebase. The line was added
in 2018.
Since `eval` is not best practice and according to ngrx#4213,
esbuild has issues with it, it is removed.
Which @ngrx/* package(s) are the source of the bug?
store-devtools
Minimal reproduction of the bug/regression with instructions
When compiling with the new esbuild system in Angular 17 (https://angular.io/guide/esbuild), the following warning is generated:
Expected behavior
No warnings should be generated.
Versions of NgRx, Angular, Node, affected browser(s) and operating system(s)
NgRx: 17.0.1
Angular: 17.0.8
Other information
No response
I would be willing to submit a PR to fix this issue
The text was updated successfully, but these errors were encountered: