Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(effects) add onResolveEffects lifecycle hook #3391

Closed
wants to merge 6 commits into from

Conversation

hizliemre
Copy link

@hizliemre hizliemre commented Apr 28, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Adds new lifecycle hook to effects. The hook can be useful when add effects manually through EffectSources.

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

There is no current behavior.
Closes #3390

What is the new behavior?

class EffectWithResolveAction implements OnResolveEffects {
   ngrxOnResolveEffects() {
    return { type: '[EffectWithResolveAction] Resolve' };
  }

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify
Copy link

netlify bot commented Apr 28, 2022

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit eeefc14
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/626a7fb5eacd68000841e037
😎 Deploy Preview https://deploy-preview-3391--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@brandonroberts
Copy link
Member

Thanks for the PR @hizliemre but let's discuss the use-case and if we need to add this first, as manually adding effects is more of an advanced API. Closing the PR until we discuss further in the issue.

@hizliemre
Copy link
Author

Thanks for your attention, @brandonroberts I started a discussion, which we can discuss here #3390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants